Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Updated jsdoc for move action #10816

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

praveendvd
Copy link
Contributor

This PR improves the selenium JS documentation regarding move action. The current documentation doesnt give clear indication on what is the default behavior if no origin is specified and when view port is specified as origin. Users might mistaken that for view port also the default behavior is to move to center of the view port (same like webelement) but the implementation is like moving to top-left corner for all other origins other than webelement.

Motivation and Context

To improve clarity on move action

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2022

CLA assistant check
All committers have signed the CLA.

@praveendvd praveendvd changed the title Updated jsdoc for move action [JS] Updated jsdoc for move action Jun 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @praveendvd !

@harsha509 harsha509 merged commit 7949433 into SeleniumHQ:trunk Jun 27, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants