-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Send data over cdp consecutively #12591
Conversation
I didn't test it locally, my build is failing. Hopefully I can grab artifacts from CI and test it. |
Perfect, I was able to build locally with |
@nvborisenko can you build selenium manager locally? That's the big difference between stamp and not stamp. @p0deje this is probably why we had it set that way in CI? |
I remember |
@titusfortner Looking at https://github.com/SeleniumHQ/selenium/actions/runs/5942888108/job/16117259011?pr=12591 - this doesn't seem to be related to Selenium-Manager. @nvborisenko Did you get the same error locally? |
Probably we should hold this and see if it is needed after merging #12614? What do you think, @nvborisenko? |
Co-authored-by: Yevgeniy Shunevych <yevgeniy.shunevych@gmail.com>
@diemol @jimevans I think we should adopt this PR and move the protection to new |
Ok, I adopted it with the latest trunk. This PR is ready for review. |
These failures have been determined to be an issue with how we are building the alert page for the test server, so I'm going to merge without these passing. |
Description
According https://learn.microsoft.com/en-us/dotnet/api/system.net.websockets.websocket
Here we ensure that we allow to send data consecutively using
SemaphoreSlim
as synchronization context.Motivation and Context
Fixes #10054
Types of changes
Checklist