Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][bidi] Remove non-relevant annotations #14013

Merged
merged 4 commits into from
May 22, 2024

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented May 22, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

BiDi tests are run again Firefox, Chrome and Edge. There were annotations that marked not implemented for IE and Safari. Removed those, since the tests were not run in those browsers.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Removed @NotYetImplemented annotations for Safari and IE from multiple test files.
  • Ensured that the tests are only run against supported browsers (Firefox, Chrome, and Edge).

Changes walkthrough 📝

Relevant files
Enhancement
21 files
BiDiSessionTest.java
Remove non-relevant annotations from BiDiSessionTest         

java/test/org/openqa/selenium/bidi/BiDiSessionTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-5     
BiDiTest.java
Remove non-relevant annotations from BiDiTest                       

java/test/org/openqa/selenium/bidi/BiDiTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-4     
BrowserCommandsTest.java
Remove non-relevant annotations from BrowserCommandsTest 

java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-7     
BrowsingContextInspectorTest.java
Remove non-relevant annotations from BrowsingContextInspectorTest

java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-18   
BrowsingContextTest.java
Remove non-relevant annotations from BrowsingContextTest 

java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-64   
LocateNodesTest.java
Remove non-relevant annotations from LocateNodesTest         

java/test/org/openqa/selenium/bidi/browsingcontext/LocateNodesTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+9/-22   
CombinedInputActionsTest.java
Remove non-relevant annotations from CombinedInputActionsTest

java/test/org/openqa/selenium/bidi/input/CombinedInputActionsTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-32   
DefaultKeyboardTest.java
Remove non-relevant annotations from DefaultKeyboardTest 

java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-20   
DefaultMouseTest.java
Remove non-relevant annotations from DefaultMouseTest       

java/test/org/openqa/selenium/bidi/input/DefaultMouseTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-35   
DefaultWheelTest.java
Remove non-relevant annotations from DefaultWheelTest       

java/test/org/openqa/selenium/bidi/input/DefaultWheelTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-16   
DragAndDropTest.java
Remove non-relevant annotations from DragAndDropTest         

java/test/org/openqa/selenium/bidi/input/DragAndDropTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-20   
ReleaseCommandTest.java
Remove non-relevant annotations from ReleaseCommandTest   

java/test/org/openqa/selenium/bidi/input/ReleaseCommandTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-5     
SetFilesCommandTest.java
Remove non-relevant annotations from SetFilesCommandTest 

java/test/org/openqa/selenium/bidi/input/SetFilesCommandTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-11   
AddInterceptParametersTest.java
Remove non-relevant annotations from AddInterceptParametersTest

java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-14   
NetworkCommandsTest.java
Remove non-relevant annotations from NetworkCommandsTest 

java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-20   
NetworkEventsTest.java
Remove non-relevant annotations from NetworkEventsTest     

java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-12   
CallFunctionParameterTest.java
Remove non-relevant annotations from CallFunctionParameterTest

java/test/org/openqa/selenium/bidi/script/CallFunctionParameterTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-20   
LocalValueTest.java
Remove non-relevant annotations from LocalValueTest           

java/test/org/openqa/selenium/bidi/script/LocalValueTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-31   
ScriptCommandsTest.java
Remove non-relevant annotations from ScriptCommandsTest   

java/test/org/openqa/selenium/bidi/script/ScriptCommandsTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-25   
ScriptEventsTest.java
Remove non-relevant annotations from ScriptEventsTest       

java/test/org/openqa/selenium/bidi/script/ScriptEventsTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-6     
StorageCommandsTest.java
Remove non-relevant annotations from StorageCommandsTest 

java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java

  • Removed @NotYetImplemented annotations for Safari and IE.
+0/-16   

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link
Contributor

PR Review 🔍

⏱️ Estimated effort to review [1-5]

2, because the PR is focused on removing specific annotations and does not introduce new functionality or complex changes. The removals are straightforward and should not require extensive testing beyond ensuring that existing tests pass without these annotations.

🧪 Relevant tests

No

⚡ Possible issues

No

🔒 Security concerns

No

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant