Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] The prebuild scripts is already decommissioned #14591

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Oct 12, 2024

User description

Description

Actualize readme how to update cdp generation in .Net.

Motivation and Context

Keep internal docs in sync.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Documentation


Description

  • Updated the README file to remove references to prebuild scripts that are no longer in use.
  • Simplified the instructions for updating the CDP generation in .NET by removing obsolete steps.

Changes walkthrough 📝

Relevant files
Documentation
README.md
Update README to remove prebuild script references             

dotnet/src/webdriver/cdp/README.md

  • Removed outdated instructions related to prebuild scripts.
  • Updated the steps for committing changes after removing a version.
  • +1/-6     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Add context about the decommissioning of prebuild scripts in the README

    Consider adding a note about the decommissioning of prebuild scripts to provide
    context for the removal of steps 4 and 5.

    dotnet/src/webdriver/cdp/README.md [55]

    -4. Commit the changes.
    +4. Note that prebuild scripts have been decommissioned, so no changes to those are necessary.
    +5. Commit the changes.
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: The suggestion provides additional context about the removal of prebuild script instructions, which could help readers understand the changes better. However, it is not critical to the functionality or correctness of the document, hence a moderate score.

    5

    💡 Need additional feedback ? start a PR chat

    @nvborisenko nvborisenko merged commit 62f6f69 into SeleniumHQ:trunk Oct 18, 2024
    8 of 10 checks passed
    @nvborisenko nvborisenko deleted the dotnet-cdp-readme branch October 22, 2024 17:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant