Fix storyboards for consistency #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n compiled for landscape only.
| @@ -43,15 +43,6 @@ | |||
| <point key="canvasLocation" x="-134" y="-498"/> | |||
| </scene> | |||
| </scenes> | |||
| <classes> | |||
There was a problem hiding this comment.
do the outlets for ipad inherit from iphone? (you tested this change for both right?? :) )
There was a problem hiding this comment.
Yeah, this is inherited from iphone. I tested on both and just manually verified that the outlets are the same in both storyboards (in the xcode ui). Everything looked kosher to me.
|
merged with 659ae85 |
IlyaNaumovich
added a commit
to IlyaNaumovich/selenium
that referenced
this pull request
Feb 11, 2018
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
add a way to initiate handshake with different peers using different PSK identity.
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
update Secure server to be compliant with new api of scandium pull request SeleniumHQ#15
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ipad and iphone storyboards were different. In this case, that caused two problems:
1: The status bar did not align properly when the app was compiled with only landscape as a supported orientation.
2: The status text never showed up when the app was forced landscape on ipad.
This fixes both issues and doesn't change functionality for the normally compiled app.
I signed the CLA.