Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] Add support for form submit in W3C mode (fixes #9916) #9936

Merged
merged 6 commits into from
Oct 20, 2021
Merged

[js] Add support for form submit in W3C mode (fixes #9916) #9936

merged 6 commits into from
Oct 20, 2021

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Oct 15, 2021 •
edited
Loading

Description

This Pr is a fix for issue #9916

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

AutomatedTester
AutomatedTester requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@AutomatedTester AutomatedTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you give a more meaningful commit as it doesn't in 1 line say what you have done.

@harsha509 harsha509 changed the title [js] Fixes #9916 [js] Add support for form submit in W3C mode (fixes #9916) Oct 20, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit 61dd966 into SeleniumHQ:trunk Oct 20, 2021
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@harsha509 @elgatov
[js] Add support for form submit in W3C mode (fixes SeleniumHQ#9916) (S…
39b3616 
…eleniumHQ#9936)

* [js] Fixes SeleniumHQ#9916

* [js] Add support for form submit in W3C mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsha509 @AutomatedTester