Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with latest autoprefixer-rails #52

Closed
jefmathiot opened this issue Nov 9, 2018 · 3 comments
Closed

Incompatibility with latest autoprefixer-rails #52

jefmathiot opened this issue Nov 9, 2018 · 3 comments

Comments

@jefmathiot
Copy link

Versions >= 9.1.4 of the autoprefixer-rails gem have deprecated therubyracer as the runtime. See https://github.com/ai/autoprefixer-rails/blob/master/lib/autoprefixer-rails/processor.rb#L149

Unfortunately, the less.rb does not seem to support the mini_racer runtime.

The workaround is to explicitely lock the autoprefixer-rails to 6.3.7. I'd be glad to submit a PR, but as the dependency has to be manually added to the Gemfiles and is not present in the gemspec, I'm not sure how I could efficiently fix the issue.

@brendon
Copy link
Collaborator

brendon commented Nov 11, 2018

I think you'd have to just lock that in your own Gemfile because, as you say, it's not one of our dependencies.

@brendon brendon closed this as completed Nov 11, 2018
@ctilley83
Copy link

Yes it is one of your dependencies.

@brendon
Copy link
Collaborator

brendon commented Feb 3, 2019

autoprefixer-rails isn't one of our dependencies, but therubyracer is a development dependency in the gemspec. The only fix we could do would be to mention that specific version of autoprefixer-rails in the readme.

This gem is becoming unviable for other reasons: #53.

I think perhaps moving away from less.rb would be the proper cure. I no longer use this gem, not have the time for a fix that big, but if you want to work on a PR that moves it away from less.rb, please do :) I'm certainly happy to help review things etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants