Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Accessibility issue when screen-reader reads out search results #1578

Closed
auroranil opened this issue Apr 13, 2017 · 10 comments
Closed

Comments

@auroranil
Copy link
Contributor

It would be great if the React integration for Semantic-UI is more screen-reader-friendly, but we understand that this issue may be out of scope. Feel free to close this issue if you think this is the case.

Steps

  1. Install a screen-reader application
  2. Go to http://react.semantic-ui.com/modules/search
  3. Click on any search component to focus on it
  4. Type something to bring up some search results
  5. Press down (or up) arrow key to select a different search result

Expected Result

The screen-reader application should be able to focus on each search result as you go up or down the search results. Once focused, the application will be able to read the text out loud from the search result.

Actual Result

The screen-reader application is unable to focus on the currently active search result, and consequently is unable to read out the text.

Version

0.67.2

@levithomason
Copy link
Member

We've had some contributions to make this library more accessible and would love more. You can reference these other PRs for guidance:

#1006 fix(Dropdown): added role/aria attributes to Dropdown and DropdownItem
#1002 fix(Icon): added aria-hidden attribute to icon ready for review
#1001 fix(List): Added aria roles for list/list-item ready for review
#892 feat(Rating): Rating now keyboard navigable and visually impaired accessible needs author feedback

@thenorthstarblues
Copy link

Hi all! I'm looking to make my first contribution to the project. Can I pick up this issue?

@levithomason
Copy link
Member

@thenorthstarblues please do, we'd be thrilled to have you. You can find helpful setup info in the CONTRIBUTING.md in the .github directory.

@thenorthstarblues
Copy link

Sounds good! Thank you.

@stale
Copy link

stale bot commented Feb 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 4, 2018
@stale stale bot closed this as completed Mar 6, 2018
@levithomason
Copy link
Member

Thanks to @rijk, we have improved how we handle stale issues, see #2761. Reopening.

@stale
Copy link

stale bot commented Aug 12, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Aug 12, 2018
@aasimsayani
Copy link

aasimsayani commented Nov 30, 2018

Hello all, is this still an issue that is open for contribution? Already looking over the CONTRIBUTING.md. @levithomason Are there any other features or aspects of the project that need to be made accessible? I would be more than happy to contribute and assist with that. Just wanted some direction before diving in! Thanks!

@stale stale bot removed the stale label Nov 30, 2018
@stale
Copy link

stale bot commented May 29, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label May 29, 2019
@stale
Copy link

stale bot commented Nov 25, 2019

This issue will be closed due to lack of activity for 12 months. If you’d like this to be reopened, just leave a comment; we do monitor them!

@stale stale bot closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants