Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown): support label prop #291

Closed
levithomason opened this issue Jun 27, 2016 · 1 comment
Closed

feat(Dropdown): support label prop #291

levithomason opened this issue Jun 27, 2016 · 1 comment

Comments

@levithomason
Copy link
Member

levithomason commented Jun 27, 2016

UPDATE

This will likely be solved by augmentation, see #414.


A Label in a labeled Input can actually be a dropdown, see here. This is not the same thing as a labeled dropdown, which separates a dropdown button icon from the button text.

Dropdown Label
image

It appears the only necessary extra dropdown class required is label. I'm not entirely sure how we want to handle this yet. We could simply add a label prop that adds this class.

I do not think we want to automatically add this when used inside an Input though. A dropdown can also appear as an Input action:

Dropdown Button
image

Dropdown
image

@levithomason levithomason changed the title Support Dropdown label prop Dropdown: Support label prop Aug 22, 2016
@levithomason
Copy link
Member Author

Solved. The Input and the Button will simply add the className when creating the Dropdown via their factories:

const labelElement = createLabel(label, { className: 'label' })

image

@levithomason levithomason changed the title Dropdown: Support label prop feat(Dropdown): support label prop Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant