fix(Icon): added aria-hidden attribute to icon #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested changes
Dec 8, 2016
| const wrapper = shallow(<Icon />) | ||
|
|
||
| wrapper.should.have.tagName('i') | ||
| wrapper.should.have.prop('aria-hidden', 'true') |
There was a problem hiding this comment.
Same comment here, let's pull these assertions into their own it() block.
fracmak
force-pushed
the
a11y-icon
branch
2 times, most recently
from
92a6f57 to
e521bdf
Compare
levithomason
approved these changes
Dec 9, 2016
|
Again, will manually test and release this later. |
|
Releasing now as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons are primary for decoration or visual style and should be hidden from screen readers. Additional markup can be added to allow screen readers to read the icons if necessary, but by default all icons should be hidden.
Documentation: http://fontawesome.io/accessibility/