Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): allow bool item value #2572

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Feb 25, 2018

Fixes #2564

@levithomason levithomason force-pushed the fix/dropdown-item-value-proptype branch from b424526 to b4da5f4 Compare February 25, 2018 21:27
@codecov-io
Copy link

Codecov Report

Merging #2572 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2572      +/-   ##
==========================================
- Coverage   99.74%   99.67%   -0.08%     
==========================================
  Files         160      160              
  Lines        2748     2748              
==========================================
- Hits         2741     2739       -2     
- Misses          7        9       +2
Impacted Files Coverage Δ
src/modules/Dropdown/DropdownItem.js 100% <ø> (ø) ⬆️
src/modules/Dropdown/Dropdown.js 100% <ø> (ø) ⬆️
src/modules/Search/Search.js 98.39% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71f7d7...b4da5f4. Read the comment docs.

@levithomason levithomason merged commit f5b65cd into master Feb 26, 2018
@levithomason levithomason deleted the fix/dropdown-item-value-proptype branch February 26, 2018 06:35
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.78.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants