fix(Responsive): fix types in typings #2633
Conversation
| } | ||
|
|
||
| export interface ResponsiveWidthShorthand { | ||
| minWidth: number; | ||
| maxWidth?: number; | ||
| minWidth?: number | string; |
There was a problem hiding this comment.
minWidth is actually optional
There was a problem hiding this comment.
This is a potentially breaking change (everyone who expects minWidth to be there and has coded against it will now potentially run into linter errors stating that minWidth is optional and should change their code to check for this).
| minWidth: number; | ||
| maxWidth?: number; | ||
| minWidth?: number | string; | ||
| maxWidth?: number | string; |
There was a problem hiding this comment.
minWidth and maxWidth can be strings, see props definitions
Codecov Report
@@ Coverage Diff @@
## master #2633 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 160 160
Lines 2750 2750
=======================================
Hits 2743 2743
Misses 7 7Continue to review full report at Codecov.
|
|
Released in |
Fixes #2608.