Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Transition): update SUI to 2.3, add zoom and glow #2658

Merged
merged 1 commit into from
Mar 18, 2018

Conversation

layershifter
Copy link
Member

Refs #2550.

This PR is a part of upgrade to SUI 2.3, add support for new Transition names zoom and glow.

@codecov-io
Copy link

Codecov Report

Merging #2658 into next will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2658      +/-   ##
==========================================
+ Coverage   99.67%   99.74%   +0.07%     
==========================================
  Files         161      160       -1     
  Lines        2762     2751      -11     
==========================================
- Hits         2753     2744       -9     
+ Misses          9        7       -2
Impacted Files Coverage Δ
src/modules/Dimmer/Dimmer.js 100% <0%> (ø) ⬆️
src/modules/Dimmer/DimmerInner.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaab06c...6ef8f37. Read the comment docs.

@layershifter layershifter merged commit 935d0ff into next Mar 18, 2018
@layershifter layershifter deleted the feat/transition-new-txs branch May 8, 2018 16:37
levithomason pushed a commit that referenced this pull request May 31, 2018
* chore(package): update SUI to 2.3

* feat(Dimmer): update SUI to 2.3, add verticalAlign (#2656)

* feat(Transition): update SUI to 2.3, add `zoom` and `glow` (#2658)

* feat(Icon): update SUI to 2.3 (#2665)

* breaking(Modal): Fix vertical position with SUI 2.3 (#2690)

* Update SUI css to 2.3.1

* Disable negative top margin calc

* Add the ability to apply inline styles to Portal

* Top Aligned modal example

* Make sure we are not overriding the top margin inline

* type defs updated for Portal

* Type update for Modal

* Refactor to use setProperty instead of string for important

* Remove inline-style lib to handle string differently

* chore(gulp): remove task with icons

* feat(Icon): regenerate icons

* docs(Usage): add warning about SUIR versions

* docs(README): remove note

* fix lint error

* fix(iconSearch): dedupe merged name sets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants