Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Container is not defined (#2684) #2706

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

rtmruczek
Copy link
Contributor

Looks like there was an issue with the regex that pulls the imports out of the component source. The previous regex assumed the imports would always be the first line, but in some cases we have some eslint disables as the first line. I modified the regex to look for previous lines, if there are any.

The editors will still break if someone is a jerk and types an import statement in the middle of the editor, though.

@codecov-io
Copy link

Codecov Report

Merging #2706 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2706   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         160      160           
  Lines        2759     2759           
=======================================
  Hits         2752     2752           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96cf1e7...5b98e4e. Read the comment docs.

@levithomason
Copy link
Member

Thanks, this seems better than what we currently have.

@levithomason levithomason merged commit a737eff into Semantic-Org:master Apr 13, 2018
@welcome
Copy link

welcome bot commented Apr 13, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in semantic-ui-react@0.80.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants