feat(Dropdown): allow autoComplete on DropdownSearchInput #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Apr 24, 2018
| @@ -18,29 +13,27 @@ class DropdownSearchInput extends Component { | |||
| /** An element type to render as (string or function). */ | |||
| as: customPropTypes.as, | |||
|
|
|||
| /** An input can have the auto complete. */ | |||
| autoComplete: PropTypes.string, | |||
There was a problem hiding this comment.
As I remember, there can be on and off values.
layershifter
commented
Apr 24, 2018
| @@ -10,15 +10,17 @@ describe('DropdownSearchInput', () => { | |||
|
|
|||
| describe('aria', () => { | |||
| it('should have aria-autocomplete', () => { | |||
| shallow(<DropdownSearchInput />) | |||
| .should.have.prop('aria-autocomplete', 'list') | |||
| shallow(<DropdownSearchInput />).should.have.prop('aria-autocomplete', 'list') | |||
There was a problem hiding this comment.
Prettier has done some work there 😃
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
==========================================
+ Coverage 99.67% 99.74% +0.07%
==========================================
Files 160 160
Lines 2761 2761
==========================================
+ Hits 2752 2754 +2
+ Misses 9 7 -2
Continue to review full report at Codecov.
|
levithomason
changed the title
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2734.
This PR allows to control a value of the
autoCompleteprop in theDropdownSearchInputcomponent.