Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Form): fix group variations typo #2823

Merged
merged 2 commits into from
May 24, 2018

Conversation

elliottcarlson
Copy link
Contributor

The message info references widths='even' which is an invalid widths type - the correct value should be equals.

The message info references `widths='even'` which is an invalid widths type - the correct value should be `equals`.
@welcome
Copy link

welcome bot commented May 23, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #2823 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2823   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         160      160           
  Lines        2773     2773           
=======================================
  Hits         2766     2766           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b6a57...a73a0cf. Read the comment docs.

@levithomason
Copy link
Member

Thank you! Fixed typo equals => equal, good to merge once tests pass.

@levithomason levithomason changed the title Update FormGroupVariationsExamples docs(FormGroupVariationsExamples): fix prop typo May 24, 2018
@levithomason levithomason changed the title docs(FormGroupVariationsExamples): fix prop typo docs(Form): fix group variations typo May 24, 2018
@levithomason levithomason merged commit b0a9a91 into Semantic-Org:master May 24, 2018
@welcome
Copy link

welcome bot commented May 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in semantic-ui-react@0.80.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants