Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): automatic upward logic in IE11 #2885

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

mihai-dinculescu
Copy link
Member

Replacing DOMRect.y with DOMRect.top because the latter seems to work in all browsers, including IE11.

@codecov-io
Copy link

Codecov Report

Merging #2885 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2885   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files         161      161           
  Lines        2733     2733           
=======================================
  Hits         2724     2724           
  Misses          9        9
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6f6eb...68d6890. Read the comment docs.

@levithomason levithomason merged commit 43793ae into master Jun 18, 2018
@levithomason levithomason deleted the fix/dropdown_upward branch June 18, 2018 23:58
@levithomason
Copy link
Member

Released in semantic-ui-react@0.81.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants