Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Examples): use react-source-render #3065

Merged
merged 3 commits into from
Aug 6, 2018
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 5, 2018

Fixes #2465.

Why?

We need more clear work with imports, fixes unhandled crashes.

Before

Unhandled crashes 😭

crash on ref

After

works

@layershifter layershifter force-pushed the docs/use-source-render branch from 21ad4f7 to e4310d3 Compare August 5, 2018 14:58
@layershifter layershifter changed the title [WIP] docs(Examples): use React Source Render [WIP] docs(Examples): use react-source-render Aug 6, 2018
@layershifter layershifter force-pushed the docs/use-source-render branch from cccaab7 to f6049af Compare August 6, 2018 10:20
@layershifter layershifter changed the title [WIP] docs(Examples): use react-source-render docs(Examples): use react-source-render Aug 6, 2018
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter layershifter force-pushed the docs/use-source-render branch from f6049af to 293a18f Compare August 6, 2018 10:22
@codecov-io
Copy link

codecov-io commented Aug 6, 2018

Codecov Report

Merging #3065 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3065   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         163      163           
  Lines        2738     2738           
=======================================
  Hits         2736     2736           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd29a3a...63f2b5a. Read the comment docs.

…React into docs/use-source-render

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

# Conflicts:
#	package.json

this.clearActiveState()
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cruft

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter layershifter merged commit a12205a into master Aug 6, 2018
@layershifter layershifter deleted the docs/use-source-render branch August 6, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion: web example not working
2 participants