Add Breadcrumb component #321
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,14 +12,29 @@ describe('Breadcrumb', () => { | |
| .should.have.tagName('div') | ||
| }) | ||
|
|
||
| const sections = [ | ||
| { text: 'Home', link: true }, | ||
| { text: 'T-Shirt', href: 'google.com' }, | ||
| ] | ||
|
|
||
| it('renders children with `sections` prop', () => { | ||
| const wrapper = shallow(<Breadcrumb sections={sections} />) | ||
|
|
||
| wrapper.find('BreadcrumbDivider').should.have.length(1) | ||
| wrapper.find('BreadcrumbSection').should.have.length(2) | ||
| }) | ||
|
|
||
| it('renders defined divider with `divider` prop', () => { | ||
| const wrapper = mount(<Breadcrumb sections={sections} divider='>' />) | ||
| const divider = wrapper.find('BreadcrumbDivider').first() | ||
|
|
||
| divider.text().should.to.equal('>') | ||
|
There was a problem hiding this comment. We use the chai-enzyme plugin. This allows us to move the enzyme method to the end of the assertion chain: -divider.text().should.to.equal('>')
+divider.should.contain.text('>')This makes for much more readable errors as well. Compare the assertion syntax here with the error messages: shallow(<Button>foo</Button>)
.text().should.equal('bar')
//=> expected 'foo' to equal 'bar'shallow(<Button>foo</Button>)
.should.contain.text('bar')
//=> expected <Button /> to contain text 'bar', but it has 'foo'
HTML:
<button type="button" class="ui button">foo</button> |
||
| }) | ||
|
|
||
| it('renders divider as `Icon` with `icon` prop', () => { | ||
|
There was a problem hiding this comment. Since common.implementsIconProp(Breadcrumb)There was a problem hiding this comment. I tried, but seems it's not solution. Breadcrumb will not become
|
||
| const icon = mount(<Breadcrumb sections={sections} icon='right mangle' />).find('Icon') | ||
|
|
||
| icon.should.have.class('right mangle') | ||
| icon.should.have.tagName('i') | ||
| }) | ||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in #321 (comment) let's use
chai-enzymeassertions for much better assertions and error messages:Compare the difference in output between
should.have.length(x)andshould.have.exactly(x).descendants(...):