Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dropdown): add support for images, icons and flags in selected values #4003

Merged
merged 6 commits into from
Jul 29, 2020
Merged

feat(Dropdown): add support for images, icons and flags in selected values #4003

merged 6 commits into from
Jul 29, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 28, 2020 •
edited
Loading

Fixes #1147.

Original PR #3980. All credits to @reefman001. Had to recreate due issues with Github CLI.

image

This PR:

  • adds a new subcomponent DropdownText to handle shorthands (nothing important actually)
  • images and flags are now visible in single selection

image
image

  • renderLabel in Dropdown has a new default value that allows to show images and flags in multiple variations

image

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 70.84 KB (0%)
bundle-size/dist/Icon.size.js 33.41 KB (0%)
bundle-size/dist/Image.size.js 66.13 KB (0%)
bundle-size/dist/Portal.size.js 49.9 KB (0%)

@layershifter layershifter mentioned this pull request Jul 28, 2020
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020 •
edited
Loading

Codecov Report

Merging #4003 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4003   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         184      185    +1     
  Lines        3234     3245   +11     
=======================================
+ Hits         3229     3240   +11     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100.00% <100.00%> (ø)
src/modules/Dropdown/DropdownText.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ec408...31767d4. Read the comment docs.

@layershifter
Merge branches 'fix_dropdown_icon_#1147' and 'master' of https://gith…
020055f 
…ub.com/Semantic-Org/Semantic-UI-React into fix_dropdown_icon_#1147

� Conflicts:
�	src/modules/Dropdown/Dropdown.js
�	test/specs/modules/Dropdown/Dropdown-test.js
@layershifter layershifter merged commit a2de6cd into master Jul 29, 2020
@layershifter layershifter deleted the fix_dropdown_icon_#1147 branch July 29, 2020 15:28
@layershifter layershifter mentioned this pull request Aug 26, 2020
Merged
This was referenced Mar 22, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: New Feature 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown: Icon isn't displayed in selection
3 participants
@layershifter @codecov-commenter @knight-coder-llc