test(factories): add factory tests #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
feature/factory-tests
branch
from
267dc85 to
d2180ca
Compare
Current coverage is 100% (diff: 100%)
|
levithomason
force-pushed
the
feature/factory-tests
branch
from
d2180ca to
4b60626
Compare
levithomason
commented
Oct 4, 2016
| @@ -16,7 +16,7 @@ const mergePropsAndClassName = (defaultProps, props) => { | |||
| newProps.className = cx(defaultProps.className, props.className) // eslint-disable-line react/prop-types | |||
| } | |||
|
|
|||
| if (!newProps.key) { | |||
| if (!newProps.key && childKey) { | |||
There was a problem hiding this comment.
Prevent adding childKey: undefined due to props with no key and also not defining a childKey. This issue was revealed by tests.
levithomason
force-pushed
the
feature/factory-tests
branch
from
4b60626 to
908ec25
Compare
|
Just force pushed |
jeffcarbs
reviewed
Oct 5, 2016
| itReturnsNullGivenDefaultPropsFunc(null) | ||
| }) | ||
|
|
||
| describe('from undefined', () => { |
There was a problem hiding this comment.
Add similar tests for booleans. Both true and false should return null
jeffcarbs
reviewed
Oct 5, 2016
| }) | ||
| } | ||
|
|
||
| const itMergesClassNames = (extraClassName, classNameSource, shorthandConfig) => { |
There was a problem hiding this comment.
Put classNameSource as first arg:
- matches
propsSourcebeing first in the functions below - currently args 1 and 3 are used in the test and 2 is used to describe the test which is a little confusing.
jeffcarbs
approved these changes
Oct 5, 2016
levithomason
force-pushed
the
feature/factory-tests
branch
from
908ec25 to
3e0d6c6
Compare
|
Thanks much, updated both suggestions. Will merge on pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
createShorthand, it does not add tests for every shorthand factory, however, they are partially applied so it is almost redundant.