Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Feed): update propTypes, shorthand and docs #575

Merged
merged 3 commits into from
Oct 2, 2016
Merged

fix(Feed): update propTypes, shorthand and docs #575

merged 3 commits into from
Oct 2, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Oct 1, 2016 •
edited
Loading

This PR pulls the Feed updates from #452. Many updates were made:

  • use content prop for main content of Feed Date/Meta/Like/etc.
  • fixed many prop type validations
  • split shorthand examples into separate files, added missing shorthand examples
  • renamed example files to FeedExampleFoo and FeedExampleFooShorthand

@levithomason levithomason changed the title fix(Feed): update props and shorthand fix(Feed): update propTypes, shorthand and docs Oct 1, 2016
@layershifter layershifter mentioned this pull request Oct 1, 2016
Closed
33 tasks
@levithomason levithomason force-pushed the fix/feed-props branch 2 times, most recently from 5b34ef2 to 8db3423 Compare October 1, 2016 23:32
@codecov-io
Copy link

codecov-io commented Oct 2, 2016 •
edited
Loading

Current coverage is 99.61% (diff: 100%)

Merging #575 into master will decrease coverage by <.01%

@@             master       #575   diff @@
==========================================
  Files           118        117     -1   
  Lines          1862       1815    -47   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1855       1808    -47   
  Misses            7          7          
  Partials          0          0

Powered by Codecov. Last update bceb7ef...2f10ecc

@levithomason
Copy link
Member Author

Just need coverage for one line, then we're good here!

image

@levithomason levithomason merged commit b12fd25 into master Oct 2, 2016
@levithomason levithomason deleted the fix/feed-props branch October 2, 2016 04:50
@levithomason
Copy link
Member Author

Released in stardust@0.51.0

@levithomason levithomason mentioned this pull request Oct 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levithomason @codecov-io