Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 1.0.0 release #2

Open
14 tasks
kghbln opened this issue May 3, 2020 · 8 comments
Open
14 tasks

Make 1.0.0 release #2

kghbln opened this issue May 3, 2020 · 8 comments
Assignees

Comments

@kghbln
Copy link
Member

kghbln commented May 3, 2020

Tracking issue for the 1.0.0 release.

  • Finalize RELEASE NOTES
  • Update "README.md"
  • Update "composer.json"
  • Update version number "extension.json"
  • Create tag
  • Add release to Wikidata
  • Update homepage
  • Announce via mail
  • Do a release tweet on Twitter
  • Run composer update on smw.o
  • Update "LocalSettings.php"
  • Start development of new version
    • Update "composer.json" (update dev alias)
    • Update "extension.json" (new alpha version)
@kghbln kghbln self-assigned this May 3, 2020
@kghbln
Copy link
Member Author

kghbln commented May 3, 2020

@mwjames I added the extension to packagist with you as maintainer and installed it on sandbox. It will be cool if you could add an example.

@mwjames
Copy link
Contributor

mwjames commented May 3, 2020

It will be cool if you could add an example.

I needed to fix the default_rule with c43705a which is why the first image doesn't show any caption yet.

@mwjames
Copy link
Contributor

mwjames commented May 3, 2020

As per rule definition, the second image will switch the caption for an available language (en, fr, de, ja) match.

@kghbln
Copy link
Member Author

kghbln commented May 3, 2020

I needed to fix the default_rule with c43705a which is why the first image doesn't show any caption yet.

Now live.

As per rule definition, the second image will switch the caption for an available language (en, fr, de, ja) match.

Cool example. Thanks for adding.

@mwjames
Copy link
Contributor

mwjames commented May 3, 2020

As a general note, image captions (generated or not) only appear when the [[File: ...]] annotation if correctly used, for details see [0].

As for galleries (e.g <gallery>...</gallery>), MediaWiki proves to be consistent in its inconsistency because listed images within a gallery tag don't run through the ImageBeforeProduceHTML hook and there is no other hook (BeforeParserFetchFileAndTitle cannot be used, AfterParserFetchFileAndTitle has access to ImageGalleryBase but it is invoked too late because the HTML has already been created) available that would provide access to image information and enable manipulation of the caption before the output for images listed as part of a gallery.

[0] https://www.mediawiki.org/wiki/Help:Images

@mwjames
Copy link
Contributor

mwjames commented May 9, 2020

The integration tests [0] showed "ArgumentCountError: Too few arguments to function SMW\ImageCaption\Hooks::onImageBeforeProduceHTML(), 7 passed in /home/travis/build/SemanticMediaWiki/mw/includes/Hooks.php on line 177 and exactly 10 expected" and after further investigation the hook signature got extended in MW 1.32 [0] which means the minimum requirement for the extension becomes MW 1.32 as it needs to have access to the Parser instance.

[0] https://travis-ci.org/github/SemanticMediaWiki/SemanticImageCaption/jobs/685146065
[1] wikimedia/mediawiki@088c6db

@kghbln
Copy link
Member Author

kghbln commented May 11, 2020

which means the minimum requirement for the extension becomes MW 1.32

This is absolutely fine since people on MW 1.31 should by now be making plans to move to MW 1.35 anyways.

@kghbln
Copy link
Member Author

kghbln commented May 11, 2020

By the time SMW 3.2 is released this extension will hopefully also be ready for MW 1.35. Keeping fingers crossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants