Why is there a Comma Behind the sender.name?

[ondohotola]

I like to have · or sometimes a hyphen - between the Name, Street and Town in the small return address line above the recipient.

I notice however, that

   sender: (
      name: "EW Lisse",
      address: [ . PO Box · Windhoek ],
   ),

results in

EW Lisse, . PO Box · Windhoek

which looks awkward.

[ondohotola]

I have no idea how to do a Pull Request, but the the diff that fixes this look slile

*** lib.typ	Wed Oct 30 23:17:19 2024
--- lib.typ.ori	Wed Oct 30 23:17:14 2024
***************
*** 288,294 ****
      }
  
      if (name != none) and (address != none) {
!       " "
      }
  
      if address != none {
--- 288,294 ----
      }
  
      if (name != none) and (address != none) {
!       ", "
      }
  
      if address != none {

[Sematre]

The reason why a comma is inserted here is, that it generates the default address line. Your patch would remove this comma.

Commas are also used as separators in the sender.address field that will be replaced by line breaks in the default header. This code will be turned into this default header.

#show: letter-simple.with(
  sender: (
    name: "Jane Smith",
    address: "Universal Exports, 1 Heavy Plaza, Morristown, NJ 07964",
  ),
  // ...
)

[Sematre]

But I have an alternative idea. There could be a new sender.address-line option that, if set, will overwrite the default value. Here's an example of how this would look like:

#show: letter-simple.with(
  sender: (
    name: "Jane Smith",
    address: "Universal Exports, 1 Heavy Plaza, Morristown, NJ 07964",
    address-line: "Jane Smith · Universal Exports · 1 Heavy Plaza · Morristown · NJ 07964"
  ),
  // ...
)

Would this work for you?

[ondohotola]

That would work very much.

As the sender rarely changes the "duplication" would not matter.

I don't use an address block but put the sender address into the footer, so I never noticed.

[Sematre]

Great. Thanks for providing feedback on this library. I'll implement this feature in the next release. Can't give an ETA tho.

[ondohotola]

Thank you.

As I don't use the sender block I'll use use the 'patched' version until 3.0.1 comes out :-)-O

[Stern1710]

This sounds pretty good. Does this enable us to "delete" the address-line by just setting the content to an empty string? And could this, per chance, then result in the space being freed? :)