Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a cubelist with duplicate protection, but still using the set numbers of cards. #581

Open
Susucre opened this issue Sep 27, 2023 · 1 comment

Comments

@Susucre
Copy link
Contributor

Susucre commented Sep 27, 2023

Hello!

It is possible currently to entirely disable duplicate protection in booster generation.
However at the xdhs we have a very particular custom set where we would like some cards to appear duplicated in boosters, but other still only appear at most once.

For instance with something similar to:

[Settings]
{
  "name": "test without protection",
  "showSlots": true,
  "withReplacement": true,
  "duplicateProtection": false
}
[Common(2)]
1 Grizzly Bears (10e) 268
1 Grizzly Bears (10e) 268
1 Lumengrid Warden (10e) 89

We would like for the possible boosters to be [Bears, Bears] (~33% chance), or [Bears, Warden] (~67% chance). However as set currently each slot in the booster is entirely independent, so it is possible to end up with [Warden, Warden]:
image

With duplicateProtection: true instead, there is only one kind of booster, [Bears, Warden], which is not what we'd want in that specific use case.

Am I right thinking what we want is not possible with existing settings? (we could set custom cards, or probability layouts, but both are heavy workarounds)

If you're alright with adding yet another boolean settings for that specific usecase, I can do the ground work and submit a PR. (not sure how to name it though)

@Senryoku
Copy link
Owner

Hello,

Note: Currently, and as far as I remember,

1 Grizzly Bears (10e) 268
1 Grizzly Bears (10e) 268

is strictly equivalent to 2 Grizzly Bears (10e) 268

Not sure how this would work in practice. We can't really use the number of copies as a customized duplicate limit for example, because it would also affect their distribution.

The duplicate check is done on the card ID, another workaround could be to use multiple versions of cards to allow duplicates even with duplicateProtection on, and possibly add custom cards if there are not enough suitable versions. But since you mentioned custom cards I guess you already though of this solution? (Note that there is a shortcut to define multiple version of a custom card: Custom cards with the same name will 'inherit' all the properties of the first one, you don't have to repeat yourself if you only want to change its set or collector number for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants