Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --exclude-id-file does not work properly with clone. #866

Open
bruno40 opened this issue May 26, 2023 · 0 comments
Open

[BUG] --exclude-id-file does not work properly with clone. #866

bruno40 opened this issue May 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@bruno40
Copy link

bruno40 commented May 26, 2023

  • [yes ] I am reporting a bug.
  • [ yes] I am running the latest version of BDfR
  • [yes ] I have read the Opening an issue

Description

--exclude-id-file does not work with clone. It does work with archive and download. The problem is concisely explained in the summary table, and here: https://pastecode.io/s/6ug2dt6v
As you can see, the excluded id is still archived. When an id is excluded in clone mode, the post will still be archived, but not downloaded. The post, 10evjbz, that was tested with has an image, which would be downloaded in clone mode if the postid had not been excluded.

The bug is not specific to this postid. It happens with every postid I have tried.

This is a summary table of the behaviour that I have found:

mode      |  id excluded  |  download jpg  |  archive json  |  logical?
download  |  yes          |  no            |  no            |  yes  
archive   |  yes          |  no            |  no            |  yes  
clone     |  yes          |  no            |  yes           |  no
download  |  no           |  yes           |  no            |  yes  
archive   |  no           |  no            |  yes           |  yes  
clone     |  no           |  yes           |  yes           |  yes

Command

bdfr clone --log log --subreddit seximal --sort top --limit 1 --exclude-id-file exclude data

When 'exclude' contains 10evjbz, assuming that 10evjbz is still the top post.

Environment (please complete the following information)

  • OS: debian stable 11.7
  • Python version: 3.9.2

Logs

log

[2023-05-26 10:14:56,481 - bdfr.connector - DEBUG] - Disabling the following modules: 
[2023-05-26 10:14:56,482 - bdfr.connector - Level 9] - Created download filter
[2023-05-26 10:14:56,482 - bdfr.connector - Level 9] - Created time filter
[2023-05-26 10:14:56,482 - bdfr.connector - Level 9] - Created sort filter
[2023-05-26 10:14:56,484 - bdfr.connector - Level 9] - Create file name formatter
[2023-05-26 10:14:56,484 - bdfr.connector - DEBUG] - Using unauthenticated Reddit instance
[2023-05-26 10:14:56,485 - bdfr.connector - Level 9] - Created site authenticator
[2023-05-26 10:15:07,313 - bdfr.connector - DEBUG] - Added submissions from subreddit Seximal
[2023-05-26 10:15:07,313 - bdfr.connector - Level 9] - Retrieved subreddits
[2023-05-26 10:15:07,313 - bdfr.connector - Level 9] - Retrieved multireddits
[2023-05-26 10:15:07,314 - bdfr.connector - Level 9] - Retrieved user data
[2023-05-26 10:15:07,314 - bdfr.connector - Level 9] - Retrieved submissions for given links
[2023-05-26 10:15:19,604 - bdfr.downloader - DEBUG] - Object 10evjbz in exclusion list, skipping
[2023-05-26 10:15:19,604 - bdfr.archive_entry.submission_archive_entry - DEBUG] - Retrieving full comment tree for submission 10evjbz
[2023-05-26 10:15:30,117 - bdfr.archiver - DEBUG] - Writing entry 10evjbz to file in JSON format at /home/brun/bdfrbug/data/Seximal/pedlan_42_When are we getting an rseximalmemes?_10evjbz.json
[2023-05-26 10:15:30,117 - bdfr.archiver - INFO] - Record for entry item 10evjbz written to disk
[2023-05-26 10:15:30,117 - root - INFO] - Program complete
@bruno40 bruno40 added the bug Something isn't working label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant