Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub link parsing changes in v1.15.1 #32

Closed
drichar opened this issue Oct 10, 2024 · 2 comments · Fixed by #37
Closed

GitHub link parsing changes in v1.15.1 #32

drichar opened this issue Oct 10, 2024 · 2 comments · Fixed by #37

Comments

@drichar
Copy link
Contributor

drichar commented Oct 10, 2024

I've noticed an issue after upgrading from v1.15.0 to v1.15.1 of the github-releases-to-discord action. Link parsing is no longer functioning as expected.

v1.15.0
image

v1.15.1
image

Previously, links to pull requests, commits, compare diffs, etc. were shortened in the generated Discord message. However, in the latest version, these links are appearing in their full form. Was this an intended change?

Additionally, while converting @ mentions to user profile links is a great enhancement, it's being applied too broadly. The package names in my release notes are being incorrectly parsed as links.

To resolve this I'll be submitting a PR that refines the regex pattern used for @ mentions to only match valid GitHub usernames.

Thank you for your time. Love the action and appreciate you building and maintaining it!

@SethCohen
Copy link
Owner

It wasn't an intended change, but whilst refactoring the code, I must've accidentally deleted the implementation. I've reimplemented this functionality in a cleaner way (07c2e1c) — should work based off my testing. Feel free to always provide any feedback, open any additional issues, or submit any PRs if ever needed. Thanks for bringing this to notice🙂

@drichar
Copy link
Contributor Author

drichar commented Oct 22, 2024

Works great now, thank you so much for fixing and for merging my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants