Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for unicode numbers #122

Closed
SethMMorton opened this issue Nov 16, 2020 · 1 comment · Fixed by #124
Closed

Better support for unicode numbers #122

SethMMorton opened this issue Nov 16, 2020 · 1 comment · Fixed by #124

Comments

@SethMMorton
Copy link
Owner

Describe the feature or enhancement

There should be some way to determine all the unicode numbers at start-up with zero runtime cost that does not require releasing a new natsort version.

Provide a concrete example of how the feature or enhancement will improve natsort

Each time a new Python version is released, natsort needs to make an update so that unit tests do not fail. Often, users spot this before I do (#104, #119). The reason I did it this way is because determining this at import time introduces a noticeable slowdown that I am unwilling to make my users incur.

I am looking for ideas/help on how to solve this so that I do not hurt user experience while simultaneously lowering maintenance burden.

@SethMMorton
Copy link
Owner Author

I am "fixing" this by making it so that the tests do not fail if this occurs. Instead the tests issue a warning, with instructions on how to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant