Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Type Hinting #135

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Conversation

thethiny
Copy link
Contributor

@thethiny thethiny commented Aug 31, 2021

Added support for type hinting for consistency with sorted from builtins.
This allows Iterables of Custom Objects to be typed.

Added support for type hinting for consistency with `sorted` from builtints.
This allows Iterables of Custom Objects to be typed.
@SethMMorton
Copy link
Owner

Any reason only natsorted was typed? And only two arguments?

@thethiny
Copy link
Contributor Author

thethiny commented Sep 7, 2021

No specific reason, it's just what I needed to make a functional work flow in my use case scenario.

@SethMMorton
Copy link
Owner

I hope you don't mind, but I will use this PR as a basis to fully type natsort.

@SethMMorton SethMMorton changed the base branch from master to type-hinting October 24, 2021 04:56
@SethMMorton SethMMorton merged commit 43b70f4 into SethMMorton:type-hinting Oct 24, 2021
@thethiny
Copy link
Contributor Author

Be my guest! Thanks for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants