Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paints render in system messages #111

Open
4 tasks done
Mm2PL opened this issue Jul 4, 2022 · 3 comments
Open
4 tasks done

Paints render in system messages #111

Mm2PL opened this issue Jul 4, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Mm2PL
Copy link

Mm2PL commented Jul 4, 2022

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

Paints render in system messages like timeouts. I would expect that either both the username color is rendered with the paint or none of them. Timeouts should keep the current behavior. /mods; /vips could have paints. Point redemption messages also don't render color therefore they probably shouldn't have paints.

Screenshots

Gayge 🌈

OS and Chatterino Version

This is on 80a08f5, freshly merged into my branch.

@Felanbird Felanbird added the enhancement New feature or request label Jul 4, 2022
@jupjohn
Copy link

jupjohn commented Jul 5, 2022

This also applies to hosting messages.

@TroyKomodo
Copy link
Member

TroyKomodo commented Jul 12, 2022

They render for both on my instance
image
image
but you are correct they didnt use to render.

Not sure which way to lean on this, should colors in timeouts be rendered or not?
Perhaps, this is a pr for upstream?

@averwhy
Copy link

averwhy commented Jan 11, 2024

I like having them, I think it should be a setting/toggle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants