Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esc/clear on a fullscreened instance un-fullscreens #272

Closed
Harjot1Singh opened this issue Nov 3, 2019 · 1 comment · Fixed by #399
Closed

Esc/clear on a fullscreened instance un-fullscreens #272

Harjot1Singh opened this issue Nov 3, 2019 · 1 comment · Fixed by #399
Labels
Impacts All Affects nearly all or all end-users! ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@Harjot1Singh
Copy link
Member

Should probably use IPC to ask electron to fullscreen, or just stick to F11 and don't override
@Harjot1Singh Harjot1Singh added Impacts Most Affects a majority of end-users. Status: Confirmed ○ Type Bug Regressions/production issues that do not function as intended. labels Nov 3, 2019
@Harjot1Singh
Copy link
Member Author

Partial resolution to use native F11 implemented.

Harjot1Singh added a commit that referenced this issue Nov 3, 2019
@Harjot1Singh
fix(frontend): remove f11 from shortcut list
bf2d0b4 
Prevents ESC key being hijacked by browser to unfullscreen

Related #272
@bhajneet bhajneet added Impacts All Affects nearly all or all end-users! and removed Impacts Most Affects a majority of end-users. labels Jan 15, 2020
Harjot1Singh added a commit that referenced this issue Jan 31, 2020
@Harjot1Singh
fix(frontend/presenter, electron): use Electron mechanism to fullscre…
ce070d0 
…en window

Note: Enables nodeIntegration

Fixes #272
@Harjot1Singh Harjot1Singh mentioned this issue Jan 31, 2020
Merged
Harjot1Singh added a commit that referenced this issue Feb 5, 2020
@Harjot1Singh
fix(frontend/presenter, electron): use Electron mechanism to fullscre…
066fe2c 
…en window

Note: Enables nodeIntegration

Fixes #272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impacts All Affects nearly all or all end-users! ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend/presenter, electron): use Electron mechanism to fullscreen window shabados/presenter
2 participants
@Harjot1Singh @bhajneet