This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Bugfix for authenticating with credentials containing special characters #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be used in the credentials
KoenZomers
changed the title
3 tasks
|
Closing this and replacing with PR #2599 as this one seems to have gotten polluted |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Using PnP PowerShell Connect-PnPOnline -Credentials (Get-Credential) with an username/password combination containing special characters would fail. URL Encoded these HTTP Form Post variables so they are correctly received by the Microsoft Online authentication endpoint.