Implementation of Facets (#310)

[nikcio]

closes #310

Currently trying to implement the proposal with the 2nd approach

• Working Implementation
• Tests
• Documentation
  I would recommend using a markdown previewer to review the docs 😄 (I updated the table of Value types with the new facet types and it's quite hard to see the change directly in markdown without preview)
• XML Documentation (See Facets XML (#311) #312)
  To avoid having to many changes in one PR this has been moved to a separate PR
• Nullable (See Facets nullable (#311 & #307) #313
  This change affects the whole project and has been moved to a separate PR

[Shazwazza]

Thanks for all the effort! Have left some comments but namely I think we need to move facets to a different interface. Let me know what you think.

[nikcio]

The comments should be resolved now @Shazwazza 😄

[nikcio]

I just noticed that I by mistake had added the Lucene.Net.Facet Nuget package to the core project. I've now removed it and created a copy of the Int64Range and DoubleRange models with an extension in the Examine.Lucene project to easily convert to the lucene equivalent model.

[Shazwazza]

Hey @callumbwhyte any chance you have time to feedback on this comment above: #311 (comment)

I've actually merged and tweaked the changes done in the WIP work that @nikcio mentions (nikcio#3) into this branch.

[nzdev]

Perhaps I'm early to respond, if so apologies as I'm trying to keep the other Facet PR's in sync. Currently the tests show that there is no implementation of IFaceting.

[Shazwazza]

@nzdev just me being too hasty :P I'll update!

[nikcio]

@Shazwazza is there anything you need help with to move forward with this PR?😅

[Shazwazza]

@nikcio was hoping @callumbwhyte could provide some feedback on the comment above #311 (comment)

[nzdev]

Fix for the missing interface issue I mentioned nikcio#4

[nzdev]

RE: #311 @Shazwazza IFacetField will need some changes to support taxonomy facets.

[nzdev]

This pr makes the facet extraction flexible enough for taxonomy facets / other faceting types to be implemented. nikcio#5

[nikcio]

@nzdev I've merged your changes I didn't notice the PR's was made in my fork sorry 😅

[nikcio]

Please let me know if I need to take action on anything else. Still crossing my fingers that this will be merged in the near future 🤞 😄

[Shazwazza]

I've merged this into a v4 branch 🎉 I'm not sure if we've addressed what @callumbwhyte had raised previously? Suppose now need to look into @nzdev PR and see what is going on there. There is a lot of changes to account for here for a new abstraction since this will all need to be applied to ExamineX too.

Before any v4 is released, we'll need to do some testing and beta releases. There's also an upcoming new Lucene beta release which contains breaking changes so need to determine if any of those breaks affect the APIs we are using before a release too.

[nzdev]

This merged pr nikcio#5 introduces IFacetExtractionContext which addresses what @callumbwhyte raised.