-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate docs site to docfx #322
Conversation
@nzdev For navbar & favicon I found: "_appLogoPath": "navlogo.svg",
"_appFaviconPath": "favicon.ico" That can be used to configure it. But docfx is missing a bunch of SoMe meta tags that the existing doc site has. Furthermore the styling in the theme as is properly needs to be looked at for this to work properly. Looking very shortly at this PR I found the following:
And as a last note the test projects should properly be excluded from the API documentation. 😅 |
Thanks @nikcio Worked around the logo and filtered the API docs. |
May be cleaner to just have v3 in docfx and have the v1/v2 on a prefix. |
I've split out the v1 / v2 docs into their own section so that any api usages can be linked to the api docs. |
Linked up a number of code references to the API docs. |
I've given this a go. But I'm very stuck. |
Output to _site/v2
This reverts commit 6a345fe.
@nzdev was trying to build these locally, I've done: Install docfx docfx --serve It builds the docs and serves them but it doesn't build the API docs and shows a ton of errors/warnings. Should this 'just work' or am I missing some conifguration? Also, I found this page about publishing to GitHub pages: https://dotnet.github.io/docfx/#publish-to-github-pages I wonder if that would make things a little more flexible? |
I think it depends on the version of docfx and what msbuild is being used. Needs to use a visual studio msbuild. |
Pretty sure it's this issue that I'm seeing dotnet/docfx#8465 |
I'd say so @Shazwazza . We had this as well on an earlier version. See https://dotnet.github.io/docfx/docs/dotnet-api-docs.html?q=msbuild#generate-from-projects-or-solutions as one possible workaround |
See also dotnet/docfx#8136 (comment). Which version of docfx are you using? I use 2.59.4.0 without issue with VS2022 and VS2019 Build Tools installed. |
Just updated to latest docfx from '2.62.1' to version '2.62.2'. So it must have been a bug they fixed. Builds great locally now. Now to figure out the rest :) |
Well I got it 'working' to deploy docfx to v2 sub folder but GitHub pages normal jekyll builds and our custom build aren't compatible with each other because they overwrite each other (more or less). I'll work on updating the new docs theme, colors, etc... and just make that the main docs :) |
Alternatively i can manually build the original jekyll docs with this https://github.com/actions/jekyll-build-pages/blob/main/action.yml but seems like too much effort for an interim thing. |
@nzdev this is live now :) https://shazwazza.github.io/Examine/ Thanks so much this is fantastic :) The branch for these docs currently are in the feature/docfx branch in the Examine repo. |
Awesome @Shazwazza . I like the header theme. |
What?
Basic migration of the existing docs site to docfx.
Why?
Improved docs experience.
How?
Created new docfx project in docs folder.
Set up docfx theme.
Migrated existing docs to docfx syntax in the /articles dir.
Configured docfx for search, improve this doc.
Configured docfx for API Docs generation.
Missing features?
Correctly sized Examine logo.How to test?
Install docfx
cd to /docs
In a command prompt run
docfx --serve
How to build?
Example for Azure DevOps
Example of docfx on github pages https://github.com/dotMorten/NmeaParser/blob/main/.github/workflows/ghpages.yml
Homepage
API Doc
Search
V3 Article
V1 / V2 Article
https://nzdev.github.io/Examine/index.html