Upgrade to storybook 7.4.1. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix-storybook-after-gatsby-v4-upgrade
to
main
September 14, 2023 02:40
This was mostly turnkey, since Storybook provides a command for automatically upgrading and even updating configuration files. One manual change that was necessary was to update the Storybook webpack configuration, which was described in terms of patching the existing webpack configuration. The patched rule changed from array index 0 to 2, so we had to update the indexes in our webpack configuration. This matches the changes described in storybookjs/storybook#22065 (comment)
richardxia
force-pushed
the
365-upgrade-storybook
branch
from
1f153d6
to
c913204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #365.
This was mostly turnkey, since Storybook provides a command for automatically upgrading and even updating configuration files.
One manual change that was necessary was to update the Storybook webpack configuration, which was described in terms of patching the existing webpack configuration. The patched rule changed from array index 0 to 2, so we had to update the indexes in our webpack configuration. This matches the changes described in
storybookjs/storybook#22065 (comment)
The biggest benefit of making this change is that it removes webpack 4 from our dependencies list. Although we had configured Storybook 6 to use webpack 5, some of Storybook's dependencies still pulled in webpack 4. Now that we've upgraded to Storybook 7, every framework we use now uses webpack 5.