Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address issues handling large dataset #27

Closed
wants to merge 2 commits into from
Closed

address issues handling large dataset #27

wants to merge 2 commits into from

Conversation

chrimerss
Copy link

@chrimerss chrimerss commented Oct 19, 2021 •
edited
Loading

Modifications to version 0.0.2

  1. Add option "save_temp" in init: this saves a ton of time without writing temporary shapefiles
  2. implemented numba to accelerate the code (replace for-loop): need some testing to see the speedup. I expect it works for large datasets.
  3. use GeoDataFrame to replace pyshp writing shapefile in method "lat_lon_SHP".

@ShervanGharari
Copy link
Owner

ShervanGharari commented Oct 19, 2021 •
edited
Loading

Greetings,
Thank you very much for opening this pull. We will perform a code review. But 2 requests/questions:
1-Can you perhaps share a snippet of the source netcdf file that you use for your case? few time steps, and one variable would be enough for our testing. you can email me the file, or a link to that if possible.
2-Also is my understanding correct that the target shapefile is Merit hydro river basin code 74?

@ShervanGharari ShervanGharari added the enhancement New feature or request label Oct 19, 2021
@ShervanGharari ShervanGharari linked an issue Oct 19, 2021 that may be closed by this pull request
Issues handling large dataset #26
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues handling large dataset
2 participants
@chrimerss @ShervanGharari