Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions for the remapped file is missing #78

Open
kasra-keshavarz opened this issue Jan 25, 2024 · 2 comments
Open

Descriptions for the remapped file is missing #78

kasra-keshavarz opened this issue Jan 25, 2024 · 2 comments

Comments

@kasra-keshavarz
Copy link
Collaborator

A brief description of the remapped .csv file could be helpful. The starting point for rows and columns in the file is not described properly, and unsure whether indexing starts from 0 or 1.

@ShervanGharari
Copy link
Owner

good point! the indexing is Python indexing so start from 0.
calculated here:
https://github.com/ShervanGharari/EASYMORE/blob/main/src/easymore/remapper.py#L1572
used here:
https://github.com/ShervanGharari/EASYMORE/blob/main/src/easymore/remapper.py#L1947
The idea to have the remapping file as NC was to include some description as well (if time allows!). It will be added in the next minor release.

@kasra-keshavarz
Copy link
Collaborator Author

The .nc could be very informative for this. This can help with mizuRoute and similar programs as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants