Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--submit-job can accept general arguments #79

Open
kasra-keshavarz opened this issue Jan 26, 2024 · 3 comments
Open

--submit-job can accept general arguments #79

kasra-keshavarz opened this issue Jan 26, 2024 · 3 comments

Comments

@kasra-keshavarz
Copy link
Collaborator

The --submit-job flag can enable accepting more argument for scheduler options. The more users are using this platform, the more flexibility is needed.

@ShervanGharari
Copy link
Owner

Thank you, I think it can be fully removed, I wanted to remove the job from the cli but kept it to accommodate the FHIMP for the time being. I prefer no job call from inside the package. user decides everything outside and calls easymore scripts, config, or cli.

@kasra-keshavarz
Copy link
Collaborator Author

So, the script will not automatically submit anything to schedulers in newer versions, is this correct?

@ShervanGharari
Copy link
Owner

Yes. The best option from my point of view would be to make the package separate from the job. I'll remove this in the future version as soon as the dependency of the FHIMP repo is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants