-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: C++20 standard requested but CXX20 is not defined #32
Comments
Thank you very much for letting me know, I just pushed the fix to BioC devel. |
@martin-g Hello I am facing the same issue. Has it resolved for you? |
@sachingadakh Yes, https://bioconductor.org/checkResults/3.18/bioc-LATEST/NanoMethViz/kunpeng2-install.html compiles fine since a while! |
Oops, I noticed after sending my previous message that the link is for Bioconductor 3.18! https://bioconductor.org/checkResults/3.19/bioc-LATEST/NanoMethViz/kunpeng2-install.html - 3.19 still fails the same way! @Shians Could you please take a new look ? |
Thanks for letting me know, how do you actually get to that page? I usually keep an eye on the build status from clicking the badge on the devel site. https://bioconductor.org/checkResults/devel/bioc-LATEST/NanoMethViz/, but it doesn't include the Linux build. I'll roll it back to C++17 again, but C++20 has been available for 3-4 years now, I'd like to figure out why it's still not properly supported on that particular build machine, or perhaps I've missed something. |
The Linux ARM64 machine is an experimental "guest builder" at Bioconductor. It is not maintained by the Bioc core team but by a community user (me).
I've contacted the Bioc core team why it has been excluded. I guess it is because of the update to R 4.4 beta that happened last week. I was a bit slow with it and maybe this caused some problems ... About C++20: the system uses by default GNU compilers version 10.3.1. I will change it to use ver. 12. I guess this will resolve the issue! I'll keep you posted! |
It was an error in ~/.R/Makevars!
but the delimiter must have been
All is fine now, even with GCC 10:
You can revert your last commit that changed C++20 to C++17 in the DESCRIPTION file! |
Hello Everyone; thanks for addressing this issue again. I seriously don't know how, but when I attempted to install the NanoMethViz on the command line Linux Ubuntu, it got installed somehow without any warnings so far, and it is reflected in the R studio as well. |
Hello,
The build of NanoMethViz at https://bioconductor.org/checkResults/3.18/bioc-LATEST/NanoMethViz/kunpeng2-install.html (Linux ARM64) fails with:
It seems this is the only Bioconductor package that requires CXX20.
I have looked around and found that it actually requires CXX17 - https://github.com/Shians/NanoMethViz/blob/master/DESCRIPTION#L82, done with b5bedf6
Assuming that the code here in Github is newer than at Bioconductor Git repo (https://code.bioconductor.org/browse/NanoMethViz/blob/devel/DESCRIPTION#L77, CXX20) I'd like to request for an update of the Bioc repo, so that the build of NanoMethViz is fixed.
Thank you!
The text was updated successfully, but these errors were encountered: