Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality of updatable waveform params #55

Open
ShiiRochi opened this issue Jun 21, 2022 · 2 comments
Open

Add functionality of updatable waveform params #55

ShiiRochi opened this issue Jun 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ShiiRochi
Copy link
Owner

ShiiRochi commented Jun 21, 2022

It would be great as the next step in the package development to implement waveform auto-update of fields that can be legally updated using wavesurfer API.

Thus, lets sum up. There are drawBuffer method and a variety of set<TLERS> methods (w/ description):

  • setBackgroundColor(color)
  • setCursorColor(color)
  • setHeight(height)
  • setFilter(filters)
  • setPlaybackRate(rate)
  • setPlayEnd(position)
  • setVolume(newVolume)
  • setMute(mute)
  • setProgressColor(color)
  • setWaveColor(color)

Those fields, that relate to the methods above will be updated by them, all other fields in theory after being changed should result in a drawBuffer or some other method call. It also should be taken into account that some fields can be updated only through reinitialization, if such exist.

@ShiiRochi ShiiRochi added the enhancement New feature or request label Jun 21, 2022
@ShiiRochi
Copy link
Owner Author

ShiiRochi commented Dec 5, 2022

Published 2.3.0-beta.0 with first attempt to introduce auto-updatable params. Currently the following list of params is watched:

  1. backgroundColor
  2. progressColor
  3. cursorColor
  4. waveColor

@ShiiRochi
Copy link
Owner Author

I would definitely add the configuration prop called UNSTABLE_enableAutoUpdate being set to false by default, because some would like to implement auto-update in another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant