Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: support "moduleResolution": "bundler" compiler option #95

Open
egorksv opened this issue May 28, 2024 · 2 comments
Open

TS: support "moduleResolution": "bundler" compiler option #95

egorksv opened this issue May 28, 2024 · 2 comments
Assignees
@ShiiRochi
Labels
help wanted Extra attention is needed P_LOW [Maintainers Only Tag] Low Priority

Comments

@egorksv
Copy link

egorksv commented May 28, 2024

Currently, any setting except for "moduleResolution": "node" breaks the build. However, "node" is VERY legacy and breaks next.js code.
Repository owner deleted a comment from github-actions bot Jun 6, 2024
@ShiiRochi ShiiRochi added enhancement New feature or request good first issue Good for newcomers P_MEDIUM [Maintainers Only Tag] Medium Priority labels Jul 16, 2024
@ShiiRochi ShiiRochi self-assigned this Jul 16, 2024
@ShiiRochi ShiiRochi linked a pull request Jul 17, 2024 that will close this issue
move to pnpm #100
Closed
@ShiiRochi
Copy link
Owner

ShiiRochi commented Jul 17, 2024 •
edited
Loading

Hi! Thanks for the ticket. I will investigate it, but I also have wavesurfer-react-next-example repo where wavesurfer-react is integrated. Take a look.

@ShiiRochi ShiiRochi removed a link to a pull request Jul 17, 2024
move to pnpm #100
Closed
@ShiiRochi
Copy link
Owner

ShiiRochi commented Jul 17, 2024 •
edited
Loading

@egorksv, I reviewed wavesurfer-react-next-example once again and find out that tsconfig there is using moduleResolution with bundler value.

It's working fine, thus I am not sure what actually happens with next.js instance in your case.

@ShiiRochi ShiiRochi added P_LOW [Maintainers Only Tag] Low Priority help wanted Extra attention is needed and removed enhancement New feature or request P_MEDIUM [Maintainers Only Tag] Medium Priority good first issue Good for newcomers labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShiiRochi ShiiRochi

Labels
help wanted Extra attention is needed P_LOW [Maintainers Only Tag] Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShiiRochi @egorksv