Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new ruin: the Abandoned Listening Post #3103

Merged
merged 20 commits into from
Jul 25, 2024

Conversation

firebudgy
Copy link
Contributor

@firebudgy firebudgy commented Jun 12, 2024

About The Pull Request

Adds a brand new ruin to Lava Worlds, a remaster of the old listening post ruin now abandoned mid-ICW and searched by the Ramzi Clique for valuables.

Major Loot:

  • Stechkin, loaded + 1 spare magazine
  • Safe containing Loadsamoney spawner and Secret Documents, plus folder to hold documents in
  • Blackbox
  • Telecommunications assembly, capable of receiving only
  • C-20r in end room with no magazine and one spare unloaded magazine
  • Scalpal, Cautery and Latex Gloves in the small infirmary

Contains for threat:

  • 3 Pistol Ramzi Commandos
  • 1 SMG Ramzi Commando
  • 1 Shotgun Ramzi Commando in the final room

StrongDMM Areas Screenshot:
image
StrongDMM No Areas Screenshot:
image
In-Game Screenshot:
image

Why It's Good For The Game

With the recent Ruincut more ruins are necessary to round out the planets in-game, and replacing a poorly designed ruin from the past with a higher-quality remake is something I like doing. This also adds an interesting environment of an abandoned holding from the ICW, of which not many exist as ruins despite the ICW being such a large event.

Changelog

🆑 Cloudbreak
add: A new ruin, the Abandoned Listening Post.
add: Areas associated with the listening post.
fix: Single line in maps catalogue.
/:cl:

@firebudgy firebudgy changed the title Adds a new Ruin: the Abandoned Listening Post Adds a new ruin: the Abandoned Listening Post Jun 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jun 12, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 12, 2024
Co-authored-by: meem <75212565+meemofcourse@users.noreply.github.com>
Signed-off-by: firebudgy <153147550+firebudgy@users.noreply.github.com>
@firebudgy firebudgy marked this pull request as ready for review June 14, 2024 03:34
@firebudgy firebudgy requested a review from a team as a code owner June 14, 2024 03:34
@FalloutFalcon FalloutFalcon added the Ruin Ruin successfully tested. label Jun 15, 2024
Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No suicide implications please.
image

Don't use RTGs as ruinloot.
image

image
Couple things. Gas tanks don't connect like this, it needs a pump in front of it. This room is all plating. Use a mix of tiles and catwalks to go over important pipes and such.

image
Two things. One, this looks rather strange because these cement tiles are supposed to only be used if paired with other cement tiles. Two, these tiles need to have the same initialization atmos as the rest of its environment or it'll cause an active turf on load, which means it takes longer and takes up resources. If you cannot find a version of the tile you want to use that matches the planetary atmos, you'll need to make a subtype of it.

image
All of these places need more clutter and decoration.

image
These areas need more decal and floorwork.

image
This air cycler needs a controller.

You need to add lightswitches.

Overall this ruin isn't bad, with a good handful of touchups this would make a good minor ruin. You can get help with addressing this review in ruinyard.

_maps/map_catalogue.txt Show resolved Hide resolved
@firebudgy firebudgy requested a review from Latentish July 15, 2024 01:52
@Latentish Latentish dismissed their stale review July 25, 2024 01:23

They did it =)

Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a guy to the engine room and you get a merge. God work here.

@Latentish Latentish added this pull request to the merge queue Jul 25, 2024
Merged via the queue into shiptest-ss13:master with commit dc0c0d8 Jul 25, 2024
14 checks passed
@firebudgy firebudgy deleted the listeningpostruinpr branch July 25, 2024 10:47
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 27, 2024
## About The Pull Request

Adds a brand new ruin to Lava Worlds, a remaster of the old listening
post ruin now abandoned mid-ICW and searched by the Ramzi Clique for
valuables.

Major Loot:
- Stechkin, loaded + 1 spare magazine
- Safe containing Loadsamoney spawner and Secret Documents, plus folder
to hold documents in
- Blackbox 
- Telecommunications assembly, capable of receiving only
- C-20r in end room with no magazine and one spare unloaded magazine
- Scalpal, Cautery and Latex Gloves in the small infirmary

Contains for threat:
- 3 Pistol Ramzi Commandos
- 1 SMG Ramzi Commando 
- 1 Shotgun Ramzi Commando in the final room

StrongDMM Areas Screenshot:

![image](https://github.com/user-attachments/assets/3735ed3d-fda3-4528-845f-8124f6957fca)
StrongDMM No Areas Screenshot:

![image](https://github.com/user-attachments/assets/14c12ef1-f323-4614-9a95-e865d6f272ac)
In-Game Screenshot:

![image](https://github.com/user-attachments/assets/5abb80d7-1363-4f1f-95b3-97a7713a761e)
## Why It's Good For The Game

With the recent Ruincut more ruins are necessary to round out the
planets in-game, and replacing a poorly designed ruin from the past with
a higher-quality remake is something I like doing. This also adds an
interesting environment of an abandoned holding from the ICW, of which
not many exist as ruins despite the ICW being such a large event.

## Changelog

:cl: Cloudbreak
add: A new ruin, the Abandoned Listening Post.
add: Areas associated with the listening post.
fix: Single line in maps catalogue.
/:cl:

---------

Signed-off-by: firebudgy <153147550+firebudgy@users.noreply.github.com>
Co-authored-by: meem <75212565+meemofcourse@users.noreply.github.com>
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
## About The Pull Request

Adds a brand new ruin to Lava Worlds, a remaster of the old listening
post ruin now abandoned mid-ICW and searched by the Ramzi Clique for
valuables.

Major Loot:
- Stechkin, loaded + 1 spare magazine
- Safe containing Loadsamoney spawner and Secret Documents, plus folder
to hold documents in
- Blackbox 
- Telecommunications assembly, capable of receiving only
- C-20r in end room with no magazine and one spare unloaded magazine
- Scalpal, Cautery and Latex Gloves in the small infirmary

Contains for threat:
- 3 Pistol Ramzi Commandos
- 1 SMG Ramzi Commando 
- 1 Shotgun Ramzi Commando in the final room

StrongDMM Areas Screenshot:

![image](https://github.com/user-attachments/assets/3735ed3d-fda3-4528-845f-8124f6957fca)
StrongDMM No Areas Screenshot:

![image](https://github.com/user-attachments/assets/14c12ef1-f323-4614-9a95-e865d6f272ac)
In-Game Screenshot:

![image](https://github.com/user-attachments/assets/5abb80d7-1363-4f1f-95b3-97a7713a761e)
## Why It's Good For The Game

With the recent Ruincut more ruins are necessary to round out the
planets in-game, and replacing a poorly designed ruin from the past with
a higher-quality remake is something I like doing. This also adds an
interesting environment of an abandoned holding from the ICW, of which
not many exist as ruins despite the ICW being such a large event.

## Changelog

:cl: Cloudbreak
add: A new ruin, the Abandoned Listening Post.
add: Areas associated with the listening post.
fix: Single line in maps catalogue.
/:cl:

---------

Signed-off-by: firebudgy <153147550+firebudgy@users.noreply.github.com>
Co-authored-by: meem <75212565+meemofcourse@users.noreply.github.com>
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants