Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SUNS Panacea-class Infirm Vessel #3112

Merged
merged 28 commits into from
Jul 3, 2024

Conversation

Latentish
Copy link
Member

@Latentish Latentish commented Jun 16, 2024

About The Pull Request

Replaces the Aegis-class with the Panacea-class Infirm Vessel. A generalist with a central theme of roleplaying around inpatients.
image
image
panaceaclass
(in game screenshot is 2 changes out of date.)

Why It's Good For The Game

Replaces an old ship and uses our new assets.

Changelog

🆑
add: Added the Panacea-class
del: Removed the Aegis-class
/:cl:

@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Jun 16, 2024
@Latentish Latentish changed the title Flowers for Aegis The Panacea-class Infirm Vessel Jun 16, 2024
@Latentish Latentish changed the title The Panacea-class Infirm Vessel The SUNS Panacea-class Infirm Vessel Jun 16, 2024
@github-actions github-actions bot added the Code change Watch something violently break. label Jun 17, 2024
@Latentish Latentish marked this pull request as ready for review June 17, 2024 07:01
@Latentish Latentish requested a review from a team as a code owner June 17, 2024 07:01
@Imaginos16
Copy link
Member

I would affectionately chew the port nacelles, you cooked so goddamn hard girl.

-adds clutter to tables
- gives some schmoney (3k starting money)
@Latentish
Copy link
Member Author

image
image
image

- adds some emergency decals
- adds intercomms
- adds a wideband
Copy link
Contributor

@meemofcourse meemofcourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen
i fail to see why the panacea needs a fire axe
imagen
i think you would benefit from replacing the base airlocks with /public airlocks
imagen
please use the syndicate factional fax subtype
imagen
minor to medium gripe but it sounds awful to have to go through the context menu every single time due to the sheer amount of bottles present. give them ghettochem tools or find some other way to lower the amount of bottles in one place
imagen
there are window firelock subtypes you can use for windows. i'm not sure if standard firelocks close when there's a window on their tile
imagen
imagen
you do not need Three Laundry Carts.
imagen
i understand using the SUNS content but i think it would make sense to issue standard breath masks in emergency lockers instead of half face masks
imagen
i think this is a ridiculous amount of engineering gear

- Nerfed engineer equipment
- replaced half masks for general use eva suits with standard breathmasks
- replaced public hamper with a sink
- replaced some doors with /public airlocks
-removed fireaxe cabinet
- replaced faxes with syndi faxes
@Latentish
Copy link
Member Author

review from meem

heavily nerfed the engi gear
image

I am going to argue that these bottles aren't really a problem because I gave them a chembag which will make sorting through them much less of a headache than rightclick context menuing it.
image

In the event of a window breaking, yes these will activate. That is the only time they need to activate.
Having firelocks in this fashion means you can use them as a psuedo airlock, which is far more useful than standard window firelocks which are just emergency atmos blockers (you have shutters already)
image

@Redrover1760
Copy link

If you give this ship a chemfridge board that'd be really helpful in keeping things sorted.

@Zevotech
Copy link
Contributor

image
accidental recharger on the floor

- Small changes to layout
- Adds sec access to more doors
- Gives engineering more basic mats for building
Copy link
Contributor

@meemofcourse meemofcourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ship smells of wet metal

@meemofcourse meemofcourse added this pull request to the merge queue Jul 3, 2024
Merged via the queue into shiptest-ss13:master with commit 986de70 Jul 3, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 4, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Replaces the Aegis-class with the Panacea-class Infirm Vessel. A
generalist with a central theme of roleplaying around inpatients.

![image](https://github.com/shiptest-ss13/Shiptest/assets/55075747/f26da6d5-baba-4921-9d66-6ac5929e8c51)

![image](https://github.com/shiptest-ss13/Shiptest/assets/55075747/e9b5c43f-0d17-442b-be1a-5af4e24cea3e)

![panaceaclass](https://github.com/shiptest-ss13/Shiptest/assets/55075747/257a7b65-c4f3-4d6d-b7f8-f750f6b16184)
(in game screenshot is 2 changes out of date.)
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Replaces an old ship and uses our new assets.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Added the Panacea-class
del: Removed the Aegis-class
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants