[Sampler] Allow passing in a Proc to enable/disable the sampler. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmansoob
commented
Sep 5, 2024
dalehamel
reviewed
Sep 5, 2024
casperisfine
reviewed
Sep 5, 2024
| end | ||
|
|
||
| def profile_sampler_enabled | ||
| return false unless defined?(@profile_sampler_enabled) |
There was a problem hiding this comment.
Suggested change
| return false unless defined?(@profile_sampler_enabled) |
You don't need that. If it's not defined then it's nil. If it's nil it isn't a Proc. So you just return nil which is close enough to false.
There was a problem hiding this comment.
If it's okay, I would like to keep it as is. We enforce True/False/Proc when setting. So if we read nil and then try to set it back, it raises - which does not seem right.
casperisfine
reviewed
Sep 5, 2024
casperisfine
approved these changes
Sep 5, 2024
bmansoob
force-pushed
the
sampler-improvements
branch
from
8f0e196
to
1c3f41b
Compare
|
Going to squash the commits now |
…me 'paths' to 'targets', making it generic
bmansoob
force-pushed
the
sampler-improvements
branch
from
1c3f41b
to
04a37af
Compare
|
Shipped this version to Core, everything is working as expected. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements for the profile sampler:
profile_sampler_enabledaccepts a Proc now. The idea is to remove the sampler we have in Core and use this.pathsin the config totargets. The idea is that the sampler can be use by Jobs too -- so it makes sense to make it generic.All changes are backwards compatible and should not break existing clients.