Merge pull request #4527 from Shopify/revert-4401-improve-binary-run-…

…safety

Revert "Improve binary run safety"

packages/cli-kit/package.json

@@ -162,7 +162,6 @@
     "tempy": "3.0.0",
     "terminal-link": "3.0.0",
     "ts-error": "1.0.6",
-    "which": "4.0.0",
     "zod": "3.22.3"
   },
   "devDependencies": {
@@ -174,7 +173,6 @@
     "@types/node": "18.19.3",
     "@types/react": "18.2.0",
     "@types/semver": "^7.5.2",
-    "@types/which": "3.0.4",
     "@vitest/coverage-istanbul": "^1.6.0",
     "node-stream-zip": "^1.15.0",
     "ts-morph": "^17.0.1",

packages/cli-kit/src/public/node/system.ts

@@ -1,12 +1,10 @@
 import {AbortSignal} from './abort.js'
-import {AbortError, ExternalError} from './error.js'
-import {cwd, dirname} from './path.js'
+import {ExternalError} from './error.js'
+import {cwd} from './path.js'
 import {treeKill} from './tree-kill.js'
 import {isTruthy} from './context/utilities.js'
-import {renderWarning} from './ui.js'
 import {shouldDisplayColors, outputDebug} from '../../public/node/output.js'
 import {execa, ExecaChildProcess} from 'execa'
-import which from 'which'
 import type {Writable, Readable} from 'stream'
 
 export interface ExecOptions {
@@ -99,7 +97,6 @@ function buildExec(command: string, args: string[], options?: ExecOptions): Exec
   if (shouldDisplayColors()) {
     env.FORCE_COLOR = '1'
   }
-  checkCommandSafety(command)
   const commandProcess = execa(command, args, {
     env,
     cwd: options?.cwd,
@@ -120,16 +117,6 @@ Running system process:
   return commandProcess
 }
 
-function checkCommandSafety(command: string) {
-  const commandDirectory = dirname(which.sync(command))
-  if (commandDirectory === cwd()) {
-    const headline = ['Skipped run of unsecure binary', {command}, 'found in the current directory.']
-    const body = 'Please remove that file or review your current PATH.'
-    renderWarning({headline, body})
-    throw new AbortError(headline, body)
-  }
-}
-
 /**
  * Waits for a given number of seconds.
  *