-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to include customer JSON templates in theme package
#1250
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Benchmark reportThe following table contains a summary of the startup time for all commands.
|
Coverage report
Test suite run success957 tests passing in 485 suites. Report generated by 🧪jest coverage report action from 51d73cf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that new files are in .zip file, thank you :)
(FYI, I updated "How to test your changes?" by adding pnpm SHOPIFY theme …
:D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mgmanzella!
WHY are these changes introduced?
Fixes #1249
WHAT is this pull request doing?
Fix to add template/customers sub directory to be added to zip file when matching directories
How to test your changes?
pnpm shopify theme init
or use existing Dawn themepnpm shopify theme package --path /path/to/package
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.