Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to include customer JSON templates in theme package #1250

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

mgmanzella
Copy link
Contributor

@mgmanzella mgmanzella commented Jan 30, 2023

WHY are these changes introduced?

Fixes #1249

WHAT is this pull request doing?

Fix to add template/customers sub directory to be added to zip file when matching directories

How to test your changes?

  • Checkout branch
  • pnpm shopify theme init or use existing Dawn theme
  • pnpm shopify theme package --path /path/to/package
  • Open zip file and navigate to templates directory, confirm customers sub directory included

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-developer-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@github-actions
Copy link
Contributor

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 1096.33 ms 1068 ms -2.58 %
🟢 app deploy 1302 ms 1316 ms 1.08 %
🟢 app dev 1302.67 ms 1315 ms 0.95 %
🟢 app env pull 1212 ms 1208.67 ms -0.28 %
🟢 app env show 1194.33 ms 1199.67 ms 0.45 %
🟢 app generate extension 1286.33 ms 1268 ms -1.43 %
🟢 app generate schema 1228.67 ms 1219.67 ms -0.73 %
🟢 app info 1204.67 ms 1222.33 ms 1.47 %
🟢 app scaffold extension 1282.67 ms 1253 ms -2.31 %
🟢 app update-url 1194.67 ms 1170.67 ms -2.01 %
🟢 theme check 1010 ms 1005.33 ms -0.46 %
🟢 theme delete 1155.67 ms 1147 ms -0.75 %
🟢 theme dev 1144 ms 1135.33 ms -0.76 %
🟢 theme help-old 1022.33 ms 1009.33 ms -1.27 %
🟢 theme info 1082.33 ms 1062.33 ms -1.85 %
🟢 theme init 1035.67 ms 1031.33 ms -0.42 %
🟢 theme language-server 1009.33 ms 1002.67 ms -0.66 %
🟢 theme list 1149.67 ms 1153.67 ms 0.35 %
🟢 theme open 1162.33 ms 1158.33 ms -0.34 %
🟢 theme package 1057.67 ms 1064 ms 0.6 %
🟢 theme publish 1154.67 ms 1136 ms -1.62 %
🟢 theme pull 1157 ms 1131 ms -2.25 %
🟢 theme push 1108.67 ms 1127.67 ms 1.71 %
🟢 theme share 1142.33 ms 1141.67 ms -0.06 %
🟢 webhook trigger 1156 ms 1144.67 ms -0.98 %

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 70.95% 3758/5297
🟡 Branches 67.98% 1654/2433
🟡 Functions 69.32% 976/1408
🟡 Lines 72.04% 3581/4971

Test suite run success

957 tests passing in 485 suites.

Report generated by 🧪jest coverage report action from 51d73cf

@mgmanzella mgmanzella marked this pull request as ready for review January 30, 2023 19:52
@mgmanzella mgmanzella requested review from a team, Arkham and matteodepalo and removed request for a team January 30, 2023 19:53
Copy link
Contributor

@Poitrin Poitrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that new files are in .zip file, thank you :)

(FYI, I updated "How to test your changes?" by adding pnpm SHOPIFY theme … :D)

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mgmanzella!

@mgmanzella mgmanzella merged commit 99b88ca into main Jan 31, 2023
@mgmanzella mgmanzella deleted the fix-1249 branch January 31, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Customer JSON templates are no longer packaged
4 participants