Modify checkout_ui template to use the new ui_extension type #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
vividviolet
commented
Feb 2, 2023
| @@ -59,7 +60,9 @@ async function generate(options: GenerateOptions) { | |||
| ) | |||
| } | |||
| } else { | |||
| specifications = specifications.filter((spec) => app.extensionsForType(spec).length < spec.registrationLimit) | |||
| specifications = specifications | |||
There was a problem hiding this comment.
@isaacroldan we have to manually filter this out for the generate command for now since we don't yet have a way to enable multiple templates for a single specification
There was a problem hiding this comment.
Makes sense!
Did you see my proposal for a new template interface in the CLI? https://github.com/Shopify/internal-cli-foundations/discussions/518
If we agree on this, we might be able to work on it soon
Benchmark reportThe following table contains a summary of the startup time for all commands.
|
vividviolet
force-pushed
the
update-checkout-ui-template
branch
2 times, most recently
from
549533f
to
b7a673b
Compare
vividviolet
changed the title
Coverage report
Test suite run success971 tests passing in 500 suites. Report generated by 🧪jest coverage report action from af42f22 |
marvinhagemeister
approved these changes
Feb 3, 2023
Remove `module` from the payload for deploying extension points as it's unused Add changeset for release Co-authored-by: Richard Powell <richardo@gmail.com> Exclude ui_extension from generate extensions tests
vividviolet
force-pushed
the
update-checkout-ui-template
branch
from
fe8748f
to
af42f22
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/ui-extensions-private/issues/2019
WHAT is this pull request doing?
ui_extensionon the generate extension prompt and remove the template forui_extensionas it's currently hardcoded to Checkout. In the future we will have multiple templates forui_extensionbut it's out of scope for this PRHow to test your changes?
pnpm shopify app generate extension --path fixtures/appCheckout UIpnpm shopify app dev --path fixtures/appand open the Preview UrlPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.