Fix dev for Ruby apps #4522
Closed
Fix dev for Ruby apps #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
gonzaloriestra
commented
Sep 25, 2024
| @@ -121,8 +121,8 @@ Running system process: | |||
| } | |||
|
|
|||
| function checkCommandSafety(command: string) { | |||
| const commandDirectory = dirname(which.sync(command)) | |||
| if (commandDirectory === cwd()) { | |||
| const commandPath = which.sync(command, {nothrow: true}) | |||
There was a problem hiding this comment.
The nothrow makes it return null instead of raising an error when the command is not found. More info: https://github.com/npm/node-which?tab=readme-ov-file#usage
Coverage report
Test suite run success1897 tests passing in 862 suites. Report generated by 🧪jest coverage report action from a84792f |
|
Closing in favor of #4527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4507
In #4401 we added a mechanism to check the safety of external binary runs from the CLI, but it caused
bin/railscommands to fail, making thedevcommand to crash with Ruby apps.WHAT is this pull request doing?
Avoid the
whichfunction to raise errors, used to find out where a binary is.How to test your changes?
Create a Ruby app and run dev
Measuring impact
How do we know this change was effective? Please choose one:
Checklist