Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for apps by title #762

Merged
merged 22 commits into from
Dec 14, 2022
Merged

Search for apps by title #762

merged 22 commits into from
Dec 14, 2022

Commits on Dec 14, 2022

  1. Search dynamically for apps based on user input

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    504ed7b View commit details
    Browse the repository at this point in the history

  2. Cache results for better performance

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    72d8b88 View commit details
    Browse the repository at this point in the history

  3. Use an event loop to avoid hitting rate limits

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    dc87138 View commit details
    Browse the repository at this point in the history

  4. Store results from all queries for final resolution 

    Previously, if the result wasn't part of the initial set of returned
apps, it wasn't found. This fixes the bug.
    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a77fb9b View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d597abc View commit details
    Browse the repository at this point in the history

  6. Fix broken tests

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    70bf79b View commit details
    Browse the repository at this point in the history

  7. Poll more often with inexpensive check

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    33494fd View commit details
    Browse the repository at this point in the history

  8. Short-circuit remote search when we have all results locally

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    caf8cba View commit details
    Browse the repository at this point in the history

  9. clarify with refactoring and comments

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9ef5466 View commit details
    Browse the repository at this point in the history

  10. Don't repeat searches

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8f91c54 View commit details
    Browse the repository at this point in the history

  11. Rename name to title

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4016c7c View commit details
    Browse the repository at this point in the history

  12. Prompt users to type when possible to search

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    515cdab View commit details
    Browse the repository at this point in the history

  13. Lint fixes

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    972fd1a View commit details
    Browse the repository at this point in the history

  14. Add changeset

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    06b6b00 View commit details
    Browse the repository at this point in the history

  15. Test fixups

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    65fda8e View commit details
    Browse the repository at this point in the history

  16. Use debounce instead: less code, better UX!

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0e72f79 View commit details
    Browse the repository at this point in the history

  17. Use promises instead of sleeping

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    93c9f8b View commit details
    Browse the repository at this point in the history

  18. Refactor for clarity

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8254a39 View commit details
    Browse the repository at this point in the history

  19. Remove unnecessary full app info returned 

    We only need the API key since we'll follow up by fetching full app info
anyway!
    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7a1a102 View commit details
    Browse the repository at this point in the history

  20. Fix broken test

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a682b27 View commit details
    Browse the repository at this point in the history

  21. Lint fixes

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    342542b View commit details
    Browse the repository at this point in the history

  22. Match user inputs case-insensitively

    @amcaplan
    amcaplan committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    3e318d9 View commit details
    Browse the repository at this point in the history