Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions to the Intersection Observer to suppress animation #2417

Closed
kjellr opened this issue Mar 16, 2023 · 1 comment
Closed

Add exceptions to the Intersection Observer to suppress animation #2417

kjellr opened this issue Mar 16, 2023 · 1 comment
Labels
Category: Enhancement New feature or request

Comments

@kjellr
Copy link
Contributor

kjellr commented Mar 16, 2023

Let's try modifying the animation observer so that:

  1. We don't trigger any animations that are visible when the page initially loads. These sections/blocks should just appear like they normally would, if animations were turned off.
  2. When sections are added/modified in the editor (and this gets triggered), those sections can also appear with no animation.
@kjellr
Copy link
Contributor Author

kjellr commented Mar 21, 2023

Closing as a duplicate of https://github.com/Shopify/themes/issues/400.

@kjellr kjellr closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant